Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Run wheel builders on labeled pull requests #21107

Merged
merged 1 commit into from
Mar 5, 2022
Merged

BLD: Run wheel builders on labeled pull requests #21107

merged 1 commit into from
Mar 5, 2022

Conversation

lithomas1
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the 36 - Build Build related PR label Feb 22, 2022
@mattip
Copy link
Member

mattip commented Feb 24, 2022

Could you add this also to the documentation, maybe around the section about skipping Ci runs.

dopplershift
dopplershift reviewed Feb 24, 2022
View reviewed changes
.github/workflows/wheels.yml Outdated
# 03 - Maintenance(for dependency upgrades), and
# 14 - Release(ensure wheels build before release)
# Note: Adding a label will not run the wheel builders on an commit made before the label was added.
# You will need to close/re-open the pull request or add another commit to trigger the wheel builders after a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if this was considered and discounted, but you could solve that by adding below under on::

    pull_request:
      types:
        - labeled
        - synchronize

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that run wheel builds only on the specific labels listed in the comment?

Copy link
Collaborator Author

@lithomas1 lithomas1 Feb 25, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think the problem with this approach is that the completed runs only show up as a check on the commit itself but not under the Checks tab for a pull request.

EDIT: I was wrong. It seems that Github fixed this, given that this didn't use to work in the past for me at least. I've made the necessary changes, and I'm so sorry for discounting your idea before trying it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I wasn't sure after you said that so I only just now verified that it works as expected. I know my experience with GHA is that "as expected" doesn't mean reality.

@lithomas1 lithomas1 force-pushed the patch-3 branch 2 times, most recently from cefded0 to 092b802 Compare February 25, 2022 04:17
@lithomas1
Copy link
Collaborator Author

Could you add this also to the documentation, maybe around the section about skipping Ci runs.

Done.

One last thing.
@mattip Could I please be added to the numpy triage team? It would be nice to be able to test that the other labels(and the various permutations of them) work before merging this (So far only 36 - Build has been tested here) and also to be able to use the labels myself on future PRs.

@mattip
Copy link
Member

mattip commented Feb 25, 2022

This looks good, assuming it does what it claims :).
@lithomas1 I added you to the triage team. Please ping me (and remove the draft status) when you are confident this works as advertised.

@lithomas1 lithomas1 changed the title BLD: Run wheel builders on labeled pull requests Run wheel builders on labeled pull requests Feb 26, 2022
@lithomas1 lithomas1 removed the 36 - Build Build related PR label Feb 26, 2022
@lithomas1 lithomas1 closed this Feb 26, 2022
@lithomas1 lithomas1 reopened this Feb 26, 2022
@lithomas1 lithomas1 changed the title Run wheel builders on labeled pull requests MAINT: Run wheel builders on labeled pull requests Feb 26, 2022
@lithomas1 lithomas1 closed this Feb 26, 2022
@lithomas1 lithomas1 reopened this Feb 26, 2022
@lithomas1 lithomas1 changed the title MAINT: Run wheel builders on labeled pull requests REL: Run wheel builders on labeled pull requests Feb 26, 2022
@lithomas1 lithomas1 changed the title REL: Run wheel builders on labeled pull requests Run wheel builders on labeled pull requests Feb 26, 2022
@lithomas1 lithomas1 closed this Feb 26, 2022
@lithomas1 lithomas1 reopened this Feb 26, 2022
@lithomas1 lithomas1 added the 36 - Build Build related PR label Feb 26, 2022
@lithomas1 lithomas1 changed the title Run wheel builders on labeled pull requests BLD: Run wheel builders on labeled pull requests Feb 26, 2022
@lithomas1 lithomas1 marked this pull request as ready for review February 26, 2022 05:02
@lithomas1 lithomas1 added 36 - Build Build related PR and removed 36 - Build Build related PR labels Feb 26, 2022
@lithomas1
Copy link
Collaborator Author

@mattip should be good to go now.

@mayeut mayeut mentioned this pull request Feb 27, 2022
Merged
@mattip
Copy link
Member

mattip commented Feb 27, 2022

Not connected to this PR, CI is having some hiccups.

  • Azure 32-bit windows is a known occasional failure
  • circleCI has started failing, see Sphinx build is broken? #21126
  • pp38 on both ubuntu and windows is failing. The non-cibuildwheel ubuntu pp38 run is passing. I wonder what is different

@lithomas1 lithomas1 force-pushed the patch-3 branch 2 times, most recently from 24caa90 to 31ad1ff Compare March 3, 2022 05:25
@lithomas1 lithomas1 requested a review from mattip March 4, 2022 23:38
@mattip mattip merged commit 95f5915 into numpy:main Mar 5, 2022
@mattip
Copy link
Member

mattip commented Mar 5, 2022

Thanks @lithomas1

@lithomas1 lithomas1 deleted the patch-3 branch March 5, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift left review comments

@mattip mattip Awaiting requested review from mattip

Assignees
No one assigned
Labels
36 - Build Build related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lithomas1 @mattip @dopplershift