BUG: Fix numba DUFuncs added loops getting picked up #21113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This needs to be tested by numba, but I currently don't have a working numba environment. (The test doesn't have to be thorough, if any DUFunc works, we should be good.) |
charris
reviewed
Feb 26, 2022
It was always my intention to do this: If no loop is found and we go into the legacy ufunc path and legacy resolving works, we need to double check that the ufunc was not mutated. Normal operation never mutates ufuncs (its really not meant to be) but numbas DUFuncs need to do it (they compile loops dynamically). The future is much brighter for them in this regard, but right now they have to keep working. Closes numpygh-20735
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was always my intention to do this: If no loop is found and we
go into the legacy ufunc path and legacy resolving works, we need
to double check that the ufunc was not mutated.
Normal operation never mutates ufuncs (its really not meant to be)
but numbas DUFuncs need to do it (they compile loops dynamically).
The future is much brighter for them in this regard, but right now
they have to keep working.
Closes gh-20735