Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: use doc_requirements.txt in azure build #21241

Merged
merged 2 commits into from Mar 25, 2022
Merged

MAINT: use doc_requirements.txt in azure build #21241

merged 2 commits into from Mar 25, 2022

Conversation

mattip
Copy link
Member

@mattip mattip commented Mar 25, 2022 •
edited by charris

Azure refguidecheck builds are failing. The configuration has sphinx 2.2. Use the doc_requirements.txt instead.

Azure refguidecheck builds are failing. Pin the sphinx and numpydoc versions.

@mattip
Copy link
Member Author

mattip commented Mar 25, 2022

No CI? Closing/repoen to retrigger.

@mattip mattip closed this Mar 25, 2022
@mattip mattip reopened this Mar 25, 2022
@mattip
Copy link
Member Author

mattip commented Mar 25, 2022

Azure is passing, can we merge this to clear the build errors?

@charris charris merged commit 4115eea into numpy:main Mar 25, 2022
@charris
Copy link
Member

charris commented Mar 25, 2022

Thanks Matti. What was the problem with doc_requirements.txt?

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Mar 25, 2022
@charris charris added this to the 1.22.4 release milestone Mar 25, 2022
charris added a commit to charris/numpy that referenced this pull request Mar 25, 2022
@charris
MAINT: Specify sphinx, numpydoc versions for CI doc builds
b42bc98 
Backport of numpy#21241.
@charris charris mentioned this pull request Mar 25, 2022
Merged
@charris charris removed this from the 1.22.4 release milestone Mar 25, 2022
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Mar 25, 2022
@mattip
Copy link
Member Author

mattip commented Mar 26, 2022

What was the problem with doc_requirements.txt?

I am not sure. test_fail[multiarray] and test_reveal failed. Maybe pip installing the doc dependencies before building installed another version of NumPy which broke the environment?

@seberg
Copy link
Member

seberg commented May 24, 2022 •
edited

Sorry, took a wrong turn somewhere. (EDIt: Deleted previous comment, hmmm, I normal hide them...)

@mattip mattip deleted the update-sphinx branch December 27, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattip @charris @seberg