BUG: Fix segmentation fault #21436
BUG: Fix segmentation fault #21436
Conversation
numpy/core/src/umath/ufunc_object.c
Outdated
| @@ -5888,6 +5888,13 @@ ufunc_at(PyUFuncObject *ufunc, PyObject *args) | |||
|
|
|||
| NPY_BEGIN_THREADS_DEF; | |||
|
|
|||
| if (ufunc->core_enabled) { | |||
| PyErr_Format(PyExc_TypeError, | |||
| "numpy.ufunc.at does not support ufunc with non-trivial "\ | |||
There was a problem hiding this comment.
Just a nit, but the \ is not necessary :).
We could probably make the error message friendlier by printing out the ufunc name rather than "numpy.ufunc.at". The name is far more interesting than the actual core signature!
numpy/core/tests/test_ufunc.py
Outdated
| a = np.array([[[1, 2], [3, 4]]]) | ||
| assert_raises(TypeError, np.linalg._umath_linalg.det.at, a, [0]) | ||
|
|
||
| # Ufunc with None signature should work as intended |
There was a problem hiding this comment.
I guess we should have tests for this already? So I think you can remove them again.
If you think they add something, just move them above to that long list for now...
| assert_raises(TypeError, np.matmul.at, a, [0], b) | ||
|
|
||
| a = np.array([[[1, 2], [3, 4]]]) | ||
| assert_raises(TypeError, np.linalg._umath_linalg.det.at, a, [0]) |
There was a problem hiding this comment.
These tests look good. But single test functions getting too long tends to be inconvenient. Could you make a new method for these two? Could just be something mentioning that gufuncs don't support at or so...
|
I have modified the functions as requested! The error message is improved, displaying both the ufunc's name and signature, and the test cases (checking that the ufunc.at throws error on nontrivial signatures) were moved to their own method. |
|
When can I expect this to get merged since the issue is fixed? |
|
@seberg Does this look good to you? |
|
Just a tiny fix, but just did that directly with a comment. Otherwise, I think it is good to go in, though. |
|
Thanks @JohnnyOu! |
|
Hi-five on merging your first pull request to NumPy, @JohnnyOu! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute |
* Fixed numpy#21301 * Fixed numpy#21436, better error message, organized test cases as requested * Update numpy/core/src/umath/ufunc_object.c Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
BUG: Fix segmentation fault (#21436)
BUG: Fixed segmentation fault with numpy.ufunc.at when ufunc has
nontrivial signature, issue #21301.
Test cases were added in numpy/core/tests/test_ufunc.py to show that
when numpy.ufunc.at uses ufunc with nontrivial signature, then
TypeError should be raised, instead of a potential segmentation fault.
Test cases were also added to show that ufunc with trivial signature is
still valid and works as intended. See issue #21301.