Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: Revert "ENH: Implement string comparison ufuncs (or almost) " #21777

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

charris
Copy link
Member

@charris charris commented Jun 16, 2022

Reverts #21716 for 1.23.0, it is causing problems downstream. See #21770.

@charris charris added the 34 - Reversion Reversion of previous commit or merge label Jun 16, 2022
@charris charris added this to the 1.23.0 release milestone Jun 16, 2022
@seberg
Copy link
Member

seberg commented Jun 16, 2022

Just as a reminder for us: This needs a reversion on the release note as well (and creation of a new snippet). But both can be seperate PRs/steps.

@charris
Copy link
Member Author

charris commented Jun 16, 2022

Just as a reminder for us

Yep. I'll do that in the prepare-for-1.21.0 PR.

@charris charris merged commit cc0e08d into maintenance/1.23.x Jun 16, 2022
@charris charris deleted the revert-21716-backport-21401 branch June 16, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
34 - Reversion Reversion of previous commit or merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants