BUG: Reorder extern "C" to only apply to function declarations in npy_math.h #21946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way incompatible included headers are not affected. Fix numpy#21802
serge-sans-paille
changed the title
charris
added
00 - Bug
component: numpy._core
09 - Backport-Candidate
charris
changed the title
|
Thanks @serge-sans-paille. I went ahead and merged this for backport to the 1.23.1 release. If you have further improvements open another PR. |
No, I went with @tacaswell 's comment in #21802. |
|
I can also confirm that the main branch now builds on the system where it was not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way incompatible included headers are not affected.
Fix #21802