Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Add Python 3.11 wheels to aarch64 build #22127

Merged
merged 1 commit into from Aug 14, 2022

Conversation

charris
Copy link
Member

@charris charris commented Aug 14, 2022

No description provided.

@charris charris added 05 - Testing 09 - Backport-Candidate PRs tagged should be backported 36 - Build Build related PR labels Aug 14, 2022
@charris charris added this to the 1.23.3 release milestone Aug 14, 2022
@charris
Copy link
Member Author

charris commented Aug 14, 2022

Apparently Python 3.11 is not available. I built the aarch64 wheel with multibuild, but it would be nice if we could make the build here more timely. Deadsnakes, perhaps?

@mattip
Copy link
Member

mattip commented Aug 14, 2022

There is CIBW_PRERELEASE_PYTHONS. The PR pypa/cibuildwheel#1226 to allow specifying 3.11 without that flag was merged 3 days ago.

@mattip
Copy link
Member

mattip commented Aug 14, 2022

Digging a little more. cibuildwheel 2.9.0 enables building 3.11 wheels without CIBW_PRERELEASE_PYTHONS

@mattip
Copy link
Member

mattip commented Aug 14, 2022

And now that I actually read the build log and this PR, I see

Is that download choice coming from cibuildwheel or from travis?

@charris
Copy link
Member Author

charris commented Aug 14, 2022

Is that download choice coming from cibuildwheel or from travis?

Don't know, but I suspect cibuildwheel isn't involved in the travis builds. For multibuild I did the old Python 3.10 for Ubuntu, Python 3.11 for manylinux2014 trick to make the wheels. I think we need something similar here. Note that travis claims to have one of the betas, but I don't know how to specify it. I'm thinking that for the wheel builds we should use the Ubuntu default Python to run the downloaded docker images so we don't need to worry about Ubuntu keeping current.

.travis.yml Outdated Show resolved Hide resolved
@charris
Copy link
Member Author

charris commented Aug 14, 2022

I would like some explanation of how this all works here. I could read the code, but that is work :)

arch: arm64
virt: vm
env:
- CIBW_BUILD: cp311-manylinux_aarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CIBW_BUILD directive determines which build is performed. You should be able to use whatever python you want in the - python: directive (line 94, 81, 68) since the build actually occurs inside a manylinux_aarch64 docker image, i.e. manylinux 2014.

@charris
Copy link
Member Author

charris commented Aug 14, 2022

The CIBW_BUILD directive determines which build is performed.

Hmm. The default Python for focal is 3.8. Let's see if it works to use 3.8 for all the wheel builds.

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@charris
Copy link
Member Author

charris commented Aug 14, 2022

Looks like specifying Python 3.8 worked and, judging by the names, the correct wheels were built.

@charris charris changed the title BLD, TST: Add Python 3.11 wheels to aarch64 build BLD: Add Python 3.11 wheels to aarch64 build Aug 14, 2022
@mattip mattip merged commit f84adef into numpy:main Aug 14, 2022
@mattip
Copy link
Member

mattip commented Aug 14, 2022

Thanks @charris

@charris
Copy link
Member Author

charris commented Aug 15, 2022

@mattip Any idea what Python is used for the tests?

@charris charris deleted the build-aarch64-311-wheels branch August 15, 2022 16:53
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 15, 2022
@charris charris removed this from the 1.23.3 release milestone Aug 15, 2022
@mattip
Copy link
Member

mattip commented Aug 15, 2022

The tests are run in the same docker image. For instance the 3.9 tests are run with python3.9 and the numpy 3.9 newly-created wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants