REV: revert change to numpyconfig.h for sizeof(type) hardcoding on macOS
#22804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…macOS Reverts numpygh-22614, and adds more detail about why that code is needed and when it can be removed. Closes numpygh-22796 [skip cirrus] [skip circle]
rgommers
added
03 - Maintenance
09 - Backport-Candidate
|
Sounds like the pragmatic and good solution to me. Thanks Ralf. |
charris
changed the title
numpyconfig.h for sizeof(type) hardcoding on macOSnumpyconfig.h for sizeof(type) hardcoding on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts gh-22614, and adds more detail about why that code is needed and when it can be removed.
Closes gh-22796
[skip cirrus]
[skip circle]