BLD: Help raspian arm + clang 13 about __builtin_mul_overflow
#22856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems on raspian arm with clang 13 `__builtin_mul_overflow` is defined for `int` but doesn't work for `ptrdiff_t` (and maybe others). This checks for `ptrdiff_t` instead of int, which was reported to work-around the issue. Closes numpygh-22811
charris
added
36 - Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems on raspian arm with clang 13
__builtin_mul_overflowis defined forintbut doesn't work forptrdiff_t(and maybe others). This checks forlong longinstead of int, which was reported to work-around the issue.Closes gh-22811
@rgommers based on the comments in the issue, is this worth a shot/helpful?