Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: use the C++ linker to link _multiarray_umath.so #23601

Merged
merged 1 commit into from Apr 16, 2023

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Apr 16, 2023

This gets rid of undefined symbol issues for assert.

Closes gh-23122
Closes gh-23595 EDIT: apparently not, something else is wrong there.

This gets rid of undefined symbol issues for `assert`.

Closes numpygh-23122
Closes numpygh-23595
@charris
Copy link
Member

charris commented Apr 16, 2023

Let's see if this works. Thanks Ralf.

@charris
Copy link
Member

charris commented Apr 16, 2023

Didn't work, same error. I think it is in the right direction, but not complete in itself. I wonder if we are running into the "hidden" problem.

@rgommers rgommers deleted the cpp-linker branch April 17, 2023 09:03
@rgommers rgommers added this to the 1.25.0 release milestone Apr 17, 2023
@rgommers
Copy link
Member Author

Build system wise this should be okay; and it did fix gh-23122. There's probably something specific in the code related to gh-23595 - let's continue dealing with that on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants