DOC: tweak NEP 50 examples #23785
Merged
DOC: tweak NEP 50 examples #23785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
May 29, 2023
seberg
reviewed
May 29, 2023
| As of the early NumPy 1.24 development branch, NumPy has preliminary and | ||
| limited support to test this proposal. To try it, you can use the | ||
| development wheels from: https://anaconda.org/scipy-wheels-nightly/numpy | ||
| As of the NumPy 1.25.x series, NumPy has preliminary and limited support to |
There was a problem hiding this comment.
Suggested change
| As of the NumPy 1.25.x series, NumPy has preliminary and limited support to | |
| As of the NumPy 1.24.x series, NumPy has preliminary and limited support to |
Actually, it was in the 1.24 dev branch, most of this works fine in 1.24 already (OTOH there are some additional fixes in 1.25).
|
Fixed the git conflict and addressed the review comment (both were on the same line). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @seberg on slack, here are several minor tweaks/additions to NEP 50 examples. Hopefully these clarify the new behavior a bit more.