New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add tests for np.argsort #23846

Merged

seberg merged 5 commits into numpy:main from r-devulap:argsort-tests

Jun 5, 2023

+42 −0

Member

r-devulap commented May 30, 2023 •

edited

Contributing a few tests I had used when developing AVX-512 based argsort. Also added a release note.


          TST: Add tests for np.argsort

6385f8e

github-actions bot added the 05 - Testing label


          DOC: Add release note for np.argsort speed up

9eceb85

r-devulap mentioned this pull request

REL: Prepare for the NumPy 1.25.0rc1 release #23832

Merged

eendebakpt reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

eendebakpt reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

eendebakpt reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

rkern reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

rkern reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved


          Minor changes based on feedback

cad6b06

rkern reviewed

View reviewed changes

numpy/core/tests/test_multiarray.py Outdated Show resolved Hide resolved

r-devulap and others added 2 commits

June 1, 2023 09:17


          Use preferred alias random instead of rand.

d5e6712

Co-authored-by: Robert Kern <robert.kern@gmail.com>


          Delete 23707.performance.rst

b914db2

seberg approved these changes

View reviewed changes

Member

seberg left a comment

Thanks everyone, looks good on a quick scan.

I took the liberty of removing the release snippet, I think Chuck is already on it (but may have missed some discussion).

seberg merged commit ea55ffa into numpy:main

14 of 35 checks passed

seberg added the 09 - Backport-Candidate label

charris pushed a commit to charris/numpy that referenced this pull request


          TST: Add tests for np.argsort (numpy#23846)

35d23ba

Contributing a few tests I had used when developing AVX-512 based argsort.

Co-authored-by: Robert Kern <robert.kern@gmail.com>

Member

charris commented Jun 5, 2023

I think Chuck is already on it

Uh ... Anyway, I don't think a release note is needed for this :)

charris mentioned this pull request

TST: Add tests for np.argsort #23878

Merged

charris removed the 09 - Backport-Candidate label

Member

seberg commented Jun 5, 2023

That was the release note for the faster argsort:

Faster ``np.argsort`` on AVX-512 enabled processors
---------------------------------------------------
32-bit and 64-bit quicksort algorithm for np.argsort gain up to 6x speed up on
processors that support AVX-512 instruction set.

Thanks to `Intel corporation <https://open.intel.com/>`_ for sponsoring this
work.

charris mentioned this pull request

TST: Add tests for np.argsort (#23846) #23882

Merged

charris added a commit that referenced this pull request


          Merge pull request #23882 from charris/backport-23846

4c34bf1

TST: Add tests for np.argsort (#23846)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment