ENH: raise early exception if 0d array is used in np.cross #24098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #24079 |
mattip
changed the title
mattip
reviewed
Jul 2, 2023
numpy/core/numeric.py
Outdated
| @@ -1581,6 +1581,10 @@ def cross(a, b, axisa=-1, axisb=-1, axisc=-1, axis=None): | |||
| axisa, axisb, axisc = (axis,) * 3 | |||
| a = asarray(a) | |||
| b = asarray(b) | |||
|
|
|||
| if (a.ndim < 1) or (b.ndim < 1): | |||
| raise Exception("At least one array has zero dimension") | |||
There was a problem hiding this comment.
If you want to catch a ValueError, you need to use ValueError as an exception. Also, there is still a grammar error in the message.
Suggested change
| raise Exception("At least one array has zero dimension") | |
| raise ValueError("At least one array has zero dimensions") |
|
@mattip Made necessary changes. |
|
Thanks @DhavalParmar61 |
|
Looks like this should not be backported. |
charris
added
01 - Enhancement
and removed
09 - Backport-Candidate
|
Sorry, I didn't consider the implications of merging this vis-a-vis backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.