DOC: Fix doc build warning for random. #24225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the file name should change too, which means changing where it is included as well. |
melissawm
reviewed
Jul 21, 2023
| @@ -6,6 +6,6 @@ Extending `numpy.random` via Cython | |||
|
|
|||
|
|
|||
| .. toctree:: | |||
| setup.py.rst | |||
| messon.build.rst | |||
There was a problem hiding this comment.
Being a bit nitpicky about the file name here:
Suggested change
| messon.build.rst | |
| meson.build.rst |
but also, I believe since this is still in transition, we may want to add a note that meson is the new build system, for those expecting a setup.py file? Something like
.. note::
Starting with NumPy 1.26.0, Meson is the default build system for NumPy.
See :ref:`distutils-status-migration`.
|
Thanks @liang3zy22 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation build warning. The original setup.py is deleted. So update it to meson.build.