-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test NumPy against OpenBLAS weekly builds #24250
Conversation
90034ad
to
0373773
Compare
@honno the failures look relevant. |
The macos-arm64 wheel build failure is due to the new code, it seems the |
Right, this is why I reverted using |
0373773
to
0250462
Compare
Fixed, all green now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Matti's suggestions I've simplified a few things... and we should actually be testing against the weekly builds of OpenBLAS now 😅
Two last things:
|
Yep, so TIL
I played around with things, no success so far. Notably |
Since this is using the |
The OpenBLAS nightly build seemingly has the same "version" as the stable build, looking at this run
I checked against Reproducing building with nightly OpenBLAS builds locally has been a huge time sink already, been hard to experiment 🙃 |
That |
926fb9b
to
656975b
Compare
Introduced a new comment as wasn't sure what to do with https://github.com/numpy/numpy/actions/runs/5716123665/job/15486923504?pr=24250#step:4:63 |
The Circle CI build wasn't touched in this PR and is only failing because this branch is behind. The Cirrus CI failures are unrelated too. Still, a few too many failures to confidently merge - let's retry that now (I merged |
This PR tests NumPy against OpenBLAS weekly builds, as well as stable builds like before.
Things to note:
linux_meson.yml
is updated to use the pre-existingcibw_before_build.sh
/openblas_support.py
scripts. These scripts are updated to support the weekly OpenBLAS builds, mirroring the changes from CI: Add prerelease build with 64bit OpenBLAS nightly scipy/scipy#18889 (testing SciPy against OpenBLAS weeklies). It feels weird to almost perfectly duplicate these scripts, and not use things likegetopt
, but it looks like they should be made redundant in the future anywho (CI: Add prerelease build with 64bit OpenBLAS nightly scipy/scipy#18889 (comment)).Before
linux_meson.yml
got OpenBLAS viaapt-get install libopenblas-serial-dev
. This PR currently pulls OpenBLAS frommultibuild-wheels-staging
... maybe there's value in testing the Ubuntu package too?We're hoping to get these stable and weekly builds that live inThat PR got merged, so we can wait on it updating to make sure things work but should be good to go. See also CI: Change OpenBLAS nightly wheel location scipy/scipy#18942multibuild-wheels-staging
toscientific-python-nightly-wheels
Upload toscientific-python-nightly-wheels
, change nightly frequency to weekly MacPython/openblas-libs#111, which looks like it could happen very soon.cc @mattip @steppi @rgommers