Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove deprecated numpy.who #24321

Merged
merged 9 commits into from Aug 16, 2023
Merged

DEP: Remove deprecated numpy.who #24321

merged 9 commits into from Aug 16, 2023

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Aug 3, 2023

Remove deprecated numpy.who.

Note: the removal is faster than the usual deprecation policy. See #23999 on the numpy 2.0 release.

@eendebakpt eendebakpt changed the title Draft: [MAINT] Remove deprecated numpy.who Draft: [DEP] Remove deprecated numpy.who Aug 3, 2023
@eendebakpt eendebakpt changed the title Draft: [DEP] Remove deprecated numpy.who [DEP] Remove deprecated numpy.who Aug 3, 2023
@charris
Copy link
Member

charris commented Aug 3, 2023

The failing test can be ignored.

@rgommers rgommers added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label Aug 4, 2023
@rgommers rgommers changed the title [DEP] Remove deprecated numpy.who DEP: Remove deprecated numpy.who Aug 4, 2023
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this effort @eendebakpt!

This LGTM. I checked back, and who was proposed for removal several times, in NEP 52, in the linked tracking issue, and the older gh-12385. I also checked that it's not used at all in SciPy, scikit-learn, Pandas, or any other projects I have a clone of locally. So this should be good to go. I'll leave it open for a bit though, best to give these deprecation/removal PRs at least a couple of days to give folks a chance to comment.

@rgommers rgommers added this to the 2.0.0 release milestone Aug 4, 2023
@seberg
Copy link
Member

seberg commented Aug 9, 2023

I guess we might have a stray release note mentioning deprecation rather than removal that might be nice to edit.

I don't think this can break production code at worst course instructions might use it. The one thing we could note is that e.g. Spyder has a variable explorer and I think there are extensions for IPython to get it too (i.e. there are nicer replacements available these days if you use rich IDEs).

@eendebakpt
Copy link
Contributor Author

The only mentioning of deprecation of who I could find was in NEP 52 in the section Cleaning up the main namespace. There it was listed as one of the examples that could be deprecated (and later removed) from the main namespace. I do not want to modify the NEP though, I think it should remain static.

@seberg
Copy link
Member

seberg commented Aug 11, 2023

Took the liberty to remove the "deprecated" part, it never was, it's an either or. I guess the deprecation was missing a release note fragment though, thanks for checking and updating.

@rgommers
Copy link
Member

This PR picked up stray changes to two git submodules, can you revert that @eendebakpt? Also there's a merge conflict now. Other than that, this looks good to merge.

@rgommers
Copy link
Member

CI is failing with ERROR .. - ImportError: cannot import name 'who' from 'numpy.lib' .

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and all CI is happy now - in it goes. Thanks again @eendebakpt!

@rgommers rgommers merged commit ceb78f2 into numpy:main Aug 16, 2023
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. Numpy 2.0 API Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants