BUG: Fix meson build failure due to unchanged inplace auto-generated dispatch config headers #24468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiko2plus
added
component: numpy.distutils
component: SIMD
…dispatch config headers Ensure that the distutils generated config files and wrapped sources, derived from dispatch-able sources are consistently generated within the build directory when the inplace build option is enabled. This change is crucial to prevent conflicts with meson-generated config headers. Given that `spin build --clean` does not remove these headers, which requires cleaning up the numpy root via `git clean` otherwise the build will fails.
seiko2plus
force-pushed
the
issue_24450
branch
from
e54ed20
to
16f7374
Compare
mattip
reviewed
Aug 21, 2023
rgommers
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
LGTM, thanks @seiko2plus
I'll leave it to @mattip to merge, since there's still an open comment from him.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the distutils generated config files and wrapped sources,
derived from dispatch-able sources are consistently generated within the build directory
when the inplace build option is enabled.
This change is crucial to prevent conflicts with meson-generated config headers.
Given that
spin build --cleandoes not remove these headers, whichrequires cleaning up the numpy root via
git cleanotherwisethe build will fails.
closes #24450