DOC: Fix some broken links #24485
Merged
DOC: Fix some broken links #24485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Aug 22, 2023
numpy/core/defchararray.py
Outdated
| @@ -1935,7 +1935,7 @@ class chararray(ndarray): | |||
| `dtype` `object_`, `bytes_` or `str_`, and use the free functions | |||
| in the `numpy.char` module for fast vectorized string operations. | |||
|
|
|||
| Versus a regular NumPy array of type `str` or `unicode`, this | |||
| Versus a regular NumPy array of type `str_` or `unicode_`, this | |||
There was a problem hiding this comment.
Hmm, str_ and unicode_ are aliases in Python 3. I think this documentation is outdated.
There was a problem hiding this comment.
"or `unicode_`" should be removed?
There was a problem hiding this comment.
chararray is slated for removal in NumPy2.0. I think copying the text from above will suffice for now, and cross-references are optional since they are used two lines above.
Suggested change
| Versus a regular NumPy array of type `str_` or `unicode_`, this | |
| Versus a NumPy array of dtype `bytes_` or ``str_`, this |
|
The test failures are not relevant. I'm not sure what to do about |
|
Thanks @F3eQnxN3RriK . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.