API: Remove deprecated msort function

[mtsokol]

Hi @rgommers @ngoldbaum,

msort was deprecated in 1.24 - this small PR removes it completely. (Plus some leftovers from removed geterrobj).

[rgommers]

LGTM, thanks @mtsokol. Could you add a release note in doc/release/upcoming_changes/24494.expired.rst?

[mtsokol]

LGTM, thanks @mtsokol. Could you add a release note in doc/release/upcoming_changes/24494.expired.rst?

Added! And how about release notes for all the previous work that was merged? Should I provide a separate PR?

[rgommers]

Added! And how about release notes for all the previous work that was merged? Should I provide a separate PR?

Hmm yeah, it's a little tricky. The current release note system is not ideal for listing many changes, and it won't assemble it well into a readable list. So I am not sure what's best. Could use towncrier snippets and then clean them up into a sane table at the end, or just keep a single list in a .rst file or an issue for now. @charris do you have any preference here?

[charris]

do you have any preference here?

I'd need to see the notes to judge. It is possible to put lists in snippets, the only PR specific bit is the link to the PR. The trick is to keep track of where the documentation is and remembering to use it in the notes. I suppose one could also make an empty PR and use it to list all the changes. For that matter, one could also edit the note itself.

[rgommers]

I suppose one could also make an empty PR and use it to list all the changes. For that matter, one could also edit the note itself.

Either one of these seems better indeed. Having a list in one place will be useful, rather than scattered over a ton of snippets. Maybe editing doc/source/release/2.0.0-notes.rst in one new PR now with the changes to date, after running towncrier once to assemble what's already there?

[rgommers]

This one is really straightforward, so in it goes.

[charris]

after running towncrier once to assemble what's already there?

I think that is reasonable. I think towncrier deletes the used snippets by default. It also used to make a separate note, but IIRC, it now adds to the existing note. In any case as long as the material is there, we can make it work at release time.

towncrier build --version "<version>"

Should work. Note that working in a branch should make this safe to experiment with.

[rgommers]

Sounds good. @mtsokol would you be able to do this? A separate PR with two commits - one for processing the existing snippets, and one for your list of additions/removals - would be useful.

[mtsokol]

Sounds good. @mtsokol would you be able to do this? A separate PR with two commits - one for processing the existing snippets, and one for your list of additions/removals - would be useful.

Sure! I will create one PR for changes that were already merged (for Part 3 and Part 4 I will add changes to PRs directly)