Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: add libquadmath to licences and other tweaks (#24753) #24785

Merged
merged 1 commit into from Sep 24, 2023

Conversation

charris
Copy link
Member

@charris charris commented Sep 23, 2023

Backport of #24753.

As pointed out in MacPython/openblas-libs#114, we are bundling libquadmath which is licensed differently than the rest of the gcc runtimes. This PR

  • adds its license, which is complicated. Most of it is copyright "Sun, with use freely granted". But there are a few files licensed under the LGPL2.0 and LGPL2.1, and even one file that is "Public domain". I am not sure what the implications are.
  • Change the canonical location of OpenBlas to https://github.com/OpenMathLib/OpenBLAS
  • Add OpenBLAS and LAPACK licences to macos, they were missing?
  • Remove the msvc runtime licenses from windows, we do not bundle it (anymore?)
  • tweak the locations of the bundles in the site-packages tree.

I think this should be backported. While #24613 to use Accelerate for macos-arm64 was backported, I see the 1.26 wheels are still using OpenBLAS, so the license should not change.

Other improvements:

  • use SPDX short specifiers, fixes from review
  • only use openblas_support.make_init() in CI, fix paths
  • fix license concatenation for wheels we distribute

Closes gh-24764

@charris charris added 08 - Backport Used to tag backport PRs 36 - Build Build related PR labels Sep 23, 2023
@charris charris added this to the 1.26.1 release milestone Sep 23, 2023
Other improvements:

- use SPDX short specifiers, fixes from review
- only use `openblas_support.make_init()` in CI, fix paths
- fix license concatenation for wheels we distribute

Closes numpygh-24764
@charris charris merged commit 2d2d856 into numpy:maintenance/1.26.x Sep 24, 2023
75 checks passed
@charris charris deleted the backport-24753 branch September 24, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 - Backport Used to tag backport PRs 36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants