-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update lexsort docstring for axis kwargs #24935
Conversation
37d6834
to
db093ff
Compare
52bcdf6
to
bf7988f
Compare
bf7988f
to
acd4bcd
Compare
[skip actions][skip cirrus][skip azp] Signed-off-by: Liang Yan <ckgppl_yan@sina.cn>
acd4bcd
to
20790a8
Compare
[skip azp] [skip actions] [skip cirrus]
I don't think this closes gh-10521; but with some adjustments, it would address the documentation part of the issue. I've taken the liberty of implementing my own suggestions for simplification. LMK if this still looks good @liang3zy22. |
[skip cirrus] [skip azp] [skip actions]
It looks good, @mdhaber . It made the lexsort doc more clear. I think my change is a tutorial for how to use lexsort and the axis parameter. |
Merging. Any more cleanup can be done in a follow-up. Thanks @liang3zy22 and @mdhaber this is a nice improvement. |
The `k` different "columns" to be sorted. The last column (or row if | ||
`keys` is a 2D array) is the primary sort key. | ||
keys : (k, m, n, ...) array-like | ||
The `k` keys to be sorted. The *last* key (e.g, the last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `k` keys to be sorted. The *last* key (e.g, the last | |
The `k` keys to be sorted. The *last* key (e.g., the last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I just meant to go through this one more time. I added that to remind myself to fix it one day, but NBD.
[skip actions][skip cirrus][skip azp]
try to address the docstring part of #10521