Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add svdvals to numpy.linalg [Array API] #24940

Merged
merged 1 commit into from Dec 5, 2023
Merged

API: Add svdvals to numpy.linalg [Array API] #24940

merged 1 commit into from Dec 5, 2023

Conversation

mtsokol
Copy link
Member

@mtsokol mtsokol commented Oct 17, 2023

This PR contains next Array API compatibility change. It adds numpy.linalg.svdvals (similar to scipy.linalg.svdvals) with docs taken from Array API specification.

@mtsokol mtsokol self-assigned this Oct 17, 2023
@mtsokol mtsokol force-pushed the array-api-svdvals branch 3 times, most recently from 3ea2567 to 71fe26a Compare October 23, 2023 10:03
charris
charris reviewed Oct 24, 2023
View reviewed changes
numpy/linalg/_linalg.py Outdated Show resolved Hide resolved
charris
charris reviewed Oct 24, 2023
View reviewed changes
numpy/linalg/_linalg.py Outdated Show resolved Hide resolved
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 28491ac to cb1e230 Compare October 25, 2023 08:42
ngoldbaum
ngoldbaum reviewed Oct 26, 2023
View reviewed changes
numpy/linalg/tests/test_linalg.py Outdated Show resolved Hide resolved
numpy/linalg/tests/test_linalg.py Show resolved Hide resolved
numpy/linalg/_linalg.py Show resolved Hide resolved
doc/release/upcoming_changes/24940.new_feature.rst Outdated Show resolved Hide resolved
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 8d1d5f5 to 9bccf09 Compare October 26, 2023 16:38
ngoldbaum
ngoldbaum approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll wait for @charris or someone else to look this over before merging since this is new API.

@rgommers rgommers added this to the 2.0.0 release milestone Oct 27, 2023
@rgommers rgommers mentioned this pull request Nov 6, 2023
Closed
23 tasks
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 94088ee to 9942713 Compare November 29, 2023 11:24
@ngoldbaum
Copy link
Member

This has a conflict that needs to be fixed

@ngoldbaum
Copy link
Member

In it goes, thanks @mtsokol!

@ngoldbaum ngoldbaum merged commit 544e54f into numpy:main Dec 5, 2023
60 of 62 checks passed
@neutrinoceros neutrinoceros mentioned this pull request Dec 7, 2023
Closed
@mtsokol mtsokol deleted the array-api-svdvals branch April 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris left review comments

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees

@mtsokol mtsokol

Labels
30 - API Numpy 2.0 API Changes
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtsokol @ngoldbaum @charris @rgommers