MAINT: test-refactor of numpy/_core/numeric.py
#25010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is unrelated |
rgommers
force-pushed
the
numpy-core-refactor
branch
from
f214867
to
460690b
Compare
|
Thanks @rgommers for the rebase |
seberg
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Sorry to nitpick, I can also live with this. But these globals seem a bit annoying. Can we rewrite it as (can also be in the class even if the class is useless)
def _test_array_equal_parametrizations():
# those are 0-d arrays, it used to be a special case
# where (_e0 == _e0).all() would raise
e0 = np.array(0, dtype='int')
e1 = np.array(1, dtype='float')
yield (e0, e0.copy(), None, True)
yield ...
that would keep locality of the variables and comparisons and just remove the weird globals.
EDIT: Which of course means using:
@pytest.mark.parametrize("...", _test_array_equal_parametrizations())
Carreau
force-pushed
the
numpy-core-refactor
branch
2 times, most recently
from
389f0fc
to
b7fc0fd
Compare
This is a pure-test refactor (as well as adding a few cases), extracted from numpy#24663. Testing each individually has a small Pytest overhead, but has the advantage of each test being able to fail independently in case of a modification of the tested function. It also make it much easier to add a new test, and I believe is much more readable. [skip cirrus] [skip circle] [skip azp]
Carreau
force-pushed
the
numpy-core-refactor
branch
from
b7fc0fd
to
39fbfe0
Compare
seberg
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure-test refactor (as well as adding a few cases), extracted from #24663.
Testing each individually has a small Pytest overhead, but has the advantage of each test being able to fail independently in case of a modification of the tested function.
It also make it much easier to add a new test, and I believe is much more readable.