TYP: add None to __getitem__ in numpy.array_api
#25022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
This was recently fixed upstream, and the discussion in data-apis/array-api#674 shows that this change can be considered a minor bug fix for earlier versions of the standard. So this is good to merge as is. Thanks @Illviljan
rgommers
changed the title
__getitem__ in numpy.array_api
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 19, 2023
charris
changed the title
__getitem__ in numpy.array_api__getitem__ in numpy.array_api
1 task
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add None to the getitem type hints.
The array_api site doesn't mention it in the getitem page until the draft version however:
https://data-apis.org/array-api/draft/API_specification/generated/array_api.array.__getitem__.html
But it is mentioned in the 2021.12 version in the indexing page:
Which of these pages takes priority?