MAINT: Make bitfield integers unsigned #25051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am getting a lot of compile warnings recently. Not sure exactly why, but one source here is that the 1 we store is cast to -1 for a signed integer bitfield. Making it explicitly unsigned quenches the warning and seems easiest.
charris
reviewed
Nov 2, 2023
| // returns '1' if the type represent a vector | ||
| int is_vector:1; | ||
| unsigned int is_vector:1; | ||
| // returns the len of multi-vector if the type represent x2 or x3 vector | ||
| // otherwise returns 0, e.g. returns 2 if data type is simd_data_vu8x2 | ||
| int is_vectorx; |
There was a problem hiding this comment.
I wonder why this isn't a bit field, must be some SIMD thing.
EDIT: Never mind. But it looks like it could also be unsigned.
|
LGTM, but I wonder how that structure is supposed to be used. Using bit fields seems a micro optimization. |
|
OK, unsigned is probably the right thing to do here. |
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting a lot of compile warnings recently. Not sure exactly why, but one source here is that the 1 we store is cast to -1 for a signed integer bitfield. Making it explicitly unsigned quenches the warning and seems easiest.
This was just the easiest. I have two other sources of warnings:
NpyAuxData. I would have thought that is fine in C, but I am getting requires C11 warning.