API: Remove PyArray_REFCNT and NPY_REFCOUNT #25156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These don't really make sense, even less as public API.
|
I can find no usages of these macros in any downstream code. Anyone trying to use this with numpy 2.0 in code I don't find with a github search will see a new compilation error with the name of the macro in it and hopefully that will be enough to find this pull request. That seems fine to me. Any other concern that I should have before hitting the merge button? This isn't an ABI break, right? And even if it is, we're about to do some of those... |
No. Exactly right, even if there was usage, it is an obvious replacement. |
|
In it goes, thanks @seberg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't really make sense, even less as public API.