Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: avoid seg fault from OOB access in RandomState.set_state() #25426

Merged
merged 1 commit into from
Dec 19, 2023
Merged

BUG: avoid seg fault from OOB access in RandomState.set_state() #25426

merged 1 commit into from
Dec 19, 2023

Conversation

ngoldbaum
Copy link
Member

Fixes #25402.

I scanned over the rest of the file and didn't see any other places where we should turn on bounds checking during input validation.

@ngoldbaum ngoldbaum added the 09 - Backport-Candidate PRs tagged should be backported label Dec 19, 2023
rkern
rkern approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@rkern rkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI failures are just hitting the CI service limits for a subset of platforms. I think the remaining CI successes are sufficient. Thank you!

@seberg seberg merged commit 0032ede into numpy:main Dec 19, 2023
61 of 64 checks passed
@charris charris mentioned this pull request Dec 22, 2023
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkern rkern rkern approved these changes

Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Segfault on np.random.set_state(())
4 participants
@ngoldbaum @rkern @seberg @charris