-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade Highway to latest released version (1.0.7) #25446
Conversation
a37847e
to
fd3c6cd
Compare
Thanks @Mousius. Let's let CI complete here, and then a rebase should make the aarch64 wheel builds on Cirrus run too. I'd be curious to see whether those pass with this update-to-latest, even if we decide to go back to the 1.0.7 release instead in the end. |
I don't think we can go back to 1.0.7, it's quite old and we've bumped a few times for fixes already. Potentially worth getting this in and then latching onto the next version release? |
fd3c6cd
to
b6866f8
Compare
Everything seems happy here, so I've disabled non-Cirrus jobs in the rerun.
Sounds reasonable to me. |
Looks like less errors, but still some errors. I'll try and take a look at this tomorrow. |
Thanks! Building locally on a manylinux aarch64 container will probably be more helpful that in CI. For macOS that's possible too with the Tart VM, see #25012 (comment). |
b6866f8
to
d40da6c
Compare
We had to pull in some git commits after the initial Highway merge, but it makes way more sense to use their well tested versions 馃樃 Hopefully fixes numpy#25445
d40da6c
to
96000c1
Compare
@rgommers I checked out I got mega test failures in Apologies for the CI resource usage 馃檧 I had to re-rebase; hopefully, those jobs get shut down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's great, thanks for checking @Mousius! This looks much better, in it goes.
I'll follow up on the last couple of unrelated test failures in the aarch64 wheel builds jobs asap, so we can get back to fully green status.
No worries about this one at all. We try to be careful, but it's secondary to getting things to work:) We burned $15 in ~48 hours, which is fine - it's more the admin hassle of it than anything else. |
We had to pull in some git commits after the initial Highway merge, but
it makes way more sense to use their well tested versions 馃樃
Hopefully fixes #25445