Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix typo in LEGACY_CONS_NON_NEGATVE_INBOUNDS_LONG #25884

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Feb 26, 2024

(missing I in NEGAT[I]VE)

@rouault rouault force-pushed the LEGACY_CONS_NON_NEGATVE_INBOUNDS_LONG branch from e4c0944 to aa70f39 Compare February 26, 2024 02:58
@rkern
Copy link
Member

rkern commented Feb 26, 2024

Notionally, this is an API change. I'd probably leave it alone.

@mattip
Copy link
Member

mattip commented Feb 26, 2024

If we want to go ahead with this, we would need to leave both declarations, make sure they are the same number in the enum, something like

LEGACY_CONS_NON_NEGATVE_INBOUNDS_LONG __attribute__((__deprecated__)) = 11

Does that work on MSVC? If not it would need some adjustment.

Maybe not worth the bother, but a comment that we know about the typo with a reference to this PR might prevent future contributors from re-submitting.

@rouault
Copy link
Contributor Author

rouault commented Feb 26, 2024

Notionally, this is an API change

is it? There's no documentation for ConstraintType nor LEGACY_CONS_NON_NEGATVE_INBOUNDS_LONG
Furthermore this was introduced very recently in Oct 2023 through b6df6cd

Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not released yet, so I we can just change it.

@rkern
Copy link
Member

rkern commented Feb 26, 2024

Okay, great!

@mattip mattip merged commit 3a45c66 into numpy:main Feb 26, 2024
62 of 63 checks passed
@mattip
Copy link
Member

mattip commented Feb 26, 2024

Thanks @rouault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants