MAINT: Introduce NPY_FEATURE_VERSION_STRING and report it in error #25948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should also allow checking what a module is compiled for since: ``` strings build/numpy/_core/_rational_tests.cpython-310-darwin.so | grep "NumPy C-API" ``` Will report the error *including* the actual NumPy "python side" version we are compatible with (so that expanding that grep should be easy for extracting the interesting value. Only modules which import NumPy will do this, I suspect that is well enough.
rgommers
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Nice. LGTM, and I verified that the error string is present in extension modules built against NumPy. A bit hard to trigger right now, because building SciPy against this branch and then running against another numpy version runs into other incompatibilities before getting to this message. But I'm reasonably sure it's right, so let's get this in.
Thanks @seberg
|
Thank you both! 🙏 |
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error message when the API version we compiled for mismatches to include the actual Python version. The big defines are a bit annoying, but not too bad.
This should also allow checking what a module is compiled for since:
Will report the error including the actual NumPy "python side" version we are compatible with (so that expanding that grep should be easy for extracting the interesting value.
Only modules which import NumPy will do this, I suspect that is well enough.
Closes gh-24861