BLD: push a tag builds a wheel #25981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If if one triggers manually, or with a pull request containing |
njzjz
reviewed
Mar 10, 2024
|
How about we put this in, backport it, and run a tag to see how it does? |
It would make sense to upload to staging when manually building maintenance branches. The nightlies are for wheels of the ongoing development in the main branch. |
|
Going to give this a shot. Thanks Andrew. |
|
There are some things you only find out about in the heat of battle. |
|
I might see if I can debig this by pushing tags to my fork. |
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Mar 11, 2024
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Mar 11, 2024
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25979.
The logic here is that:
Pushing to a maintenance branch starts a CI run.github.refstarts withrefs/tags/vand doesn't end withdev0then the wheel builder runsIS_PUSHvariable.