BUG: adapt cython files to new complex declarations (#26080) #26109
+216
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes numpy#26029 declare npy_cfloat and friends as empty structs declare cfloat_t and friends as ctypedef float complex cfloat_t, without being directly connected to npy_cfloat. This allows still using .imag and .real attributes, which Cython wraps with macros add a test for BUG: changing the complex struct has implications for Cython numpy#26029, it passes since we use C compilation for cython. The inplace += will fail on C++. resync the two cython pxd files. At what point do we declare NumPy requires Cython3? I checked that scipy and cython can use the pxd file. --------- Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net> Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26080.
Fixes #26029
npy_cfloatand friends as empty structscfloat_tand friends asctypedef float complex cfloat_t, without being directly connected tonpy_cfloat. This allows still using.imagand.realattributes, which Cython wraps with macros+=will fail on C++.pxdfiles. At what point do we declare NumPy requires Cython3?I checked that scipy and cython can use the
pxdfile.Edit: I checked on linux, I did not check MSVC