Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG,MAINT: Fix __array__ bugs and simplify code #26142

Merged
merged 4 commits into from Mar 29, 2024
Merged

BUG,MAINT: Fix __array__ bugs and simplify code #26142

merged 4 commits into from Mar 29, 2024

Commits on Mar 27, 2024

  1. BUG,MAINT: Fix __array__ bugs and simplify code 

    This fixes that the UserWarning is incorrect, it needs to be a
DeprecationWarning (it does not related to end-users).
Instead, include the information about `copy=None` into the error
message.

It also fixes a bug:  If `copy=` kwarg is unsupported we cannot
guarantee no-copy, so we should raise, or did we discuss to "just warn"?

That is also a latent bug: When `copy=True` and the fallback path
is taken, then we must make a copy to be on the safe side.
    @seberg
    seberg committed Mar 27, 2024
    Copy the full SHA
    2c08c3f View commit details
    Browse the repository at this point in the history

  2. Address Marten's review comments

    @seberg
    seberg committed Mar 27, 2024
    Copy the full SHA
    c9fbd08 View commit details
    Browse the repository at this point in the history

  3. DOC: Include full link to migration guide and tweak nocopy error

    @seberg
    seberg committed Mar 27, 2024
    Copy the full SHA
    6b67596 View commit details
    Browse the repository at this point in the history

  4. TST: Fixup test for changed error message...

    @seberg
    seberg committed Mar 27, 2024
    Copy the full SHA
    973b99f View commit details
    Browse the repository at this point in the history