ENH: add functionality symlog to numpy.histogram
#26287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MycrofD
force-pushed
the
feat-histograms-symlogbins
branch
3 times, most recently
from
1d2108f
to
3721747
Compare
MycrofD
force-pushed
the
feat-histograms-symlogbins
branch
from
3721747
to
73a04bb
Compare
MycrofD
changed the title
MycrofD
changed the title
symlog to numpy.histogram
eendebakpt
reviewed
Apr 16, 2024
| Compute the bin edges for a histogram with geometrically spaced bins. | ||
| The bins are spaced such that the width of each bin is constant in | ||
| log-space. | ||
| Reference issue: https://github.com/numpy/numpy/issues/24368 |
There was a problem hiding this comment.
Suggested change
| Reference issue: https://github.com/numpy/numpy/issues/24368 |
No need to include references to github issues for user documentation
| @@ -383,6 +383,17 @@ def _get_bin_edges(a, bins, range, weights): | |||
| # parse the overloaded bins argument | |||
| n_equal_bins = None | |||
| bin_edges = None | |||
| if symlog: | |||
| if np.ndim(bins) != 0: | |||
| warnings.warn( | |||
There was a problem hiding this comment.
This should raise an error
Comment on lines
+394
to
+395
| n_unequal_bins = bins | ||
| bin_edges = _get_geomspace_edges(n_unequal_bins, a) |
There was a problem hiding this comment.
Suggested change
| n_unequal_bins = bins | |
| bin_edges = _get_geomspace_edges(n_unequal_bins, a) | |
| bin_edges = _get_geomspace_edges(bins, a) |
| @@ -453,6 +464,37 @@ def _get_bin_edges(a, bins, range, weights): | |||
| return bin_edges, None | |||
|
|
|||
|
|
|||
| def _get_geomspace_edges(n_unequal_bins, a): | |||
There was a problem hiding this comment.
Suggested change
| def _get_geomspace_edges(n_unequal_bins, a): | |
| def _get_geomspace_edges(a, n_unequal_bins): |
(keep the same order as _get_bin_edges)
eendebakpt
reviewed
Apr 16, 2024
| """ | ||
| # The idea is to use the absolute min and max of the data to compute the | ||
| # range, and then the pseudo-first and last edge. | ||
| pseudo_first_edge, pseudo_last_edge = abs(a).min(), abs(a).max() |
There was a problem hiding this comment.
Suggested change
| pseudo_first_edge, pseudo_last_edge = abs(a).min(), abs(a).max() | |
| abs_a = abs(a) | |
| pseudo_first_edge, pseudo_last_edge = abs_a.min(), abs_a.max() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parameter called
symlogtonumpy.histogram.Details are in the issue raised at #24368.
Briefly, it gives geometrically spaced bins for data containing positive and negative values when an integer number of bins are asked for.