Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add llvm/clang sanitizer tests #26308

Closed
wants to merge 2 commits into from

Conversation

ngoldbaum
Copy link
Member

Closes #25875.

Should fix the test hang in #26307.

@ngoldbaum ngoldbaum added the 08 - Backport Used to tag backport PRs label Apr 18, 2024
@charris
Copy link
Member

charris commented Apr 18, 2024

Seems to be hung.

@ngoldbaum
Copy link
Member Author

Darn it's hanging in the same place as the gcc_sanitizers test used to hang.

I added faulthander_timeout which should prevent hangs and hopefully let us get a traceback if this happens again. I'll add it to the main branch as well. I'll also increase the timeout if 120 seconds is too short.

@ngoldbaum ngoldbaum force-pushed the backport-26295 branch 2 times, most recently from b2f0414 to 2273500 Compare April 19, 2024 00:02
@ngoldbaum
Copy link
Member Author

I've manually run the tests several times but haven't been able to reproduce the hang. Let me know if you notice this job hanging after merging this PR. I'll try to keep an eye on the action run log.

@charris
Copy link
Member

charris commented Apr 19, 2024

The documentation backport hung, #26312. Let's see how this goes.

@charris
Copy link
Member

charris commented Apr 19, 2024

Thanks Nathan.

@rgommers
Copy link
Member

You probably want to close this backport PR I think. There's little need for having sanitizers in the maintenance branch, and if there's still potential reliability problems then it's best to continue improving things in main.

@ngoldbaum
Copy link
Member Author

We turned on the workflow again, but the backport branch still had the old definition. This was supposed to ensure there wouldn't be test hangs on the backport branch.

@charris charris closed this Apr 23, 2024
@charris
Copy link
Member

charris commented Apr 23, 2024

We will still need to disable the test in the 2.0.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants