TST: Skip Cython test for editable install #26325
Conversation
There was a problem hiding this comment.
See also cython/cython#5820 for a similar discussion.
This LGTM, I am not 100% sure if there may be a better way to detect "editable", but this also seems fine to just use.
This doesn't remove the pain that you may not be able to develop downstream cython modules if you install NumPy with an editable install. But there isn't much to do about that...
[skip circle]
thalassemia
force-pushed
the
editable-skip
branch
from
294f420
to
418f0ee
Compare
Also make it work with meson-python 0.15.0 (that returns an empty list for `__path__`).
The main reason is that tests with a compile step cannot work, because headers aren't found. The distutils test could be made to work, but that isn't worth the effort since it's deprecated code.
|
Thanks @thalassemia! I tweaked the check for editable install a bit to ensure it works with |
Yes we definitely should. I'd prefer to open a follow-up issue for that though, since making CI happy takes time/iterations. |
|
SGTM, merging. Thanks @thalassemia! |
Skip testing Cython extension for editable installs due to issues identified in scipy/scipy#20540.