Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]ENH: Convert loop unary fp rint into highway #26346

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[WIP]ENH: Convert loop unary fp rint into highway #26346

wants to merge 9 commits into from
+229 −265

Conversation

luyahan
Copy link

@luyahan luyahan commented Apr 25, 2024 •
edited

refer #24384, #24385

@luyahan luyahan changed the title rewrite loop rint into HIGHWAY ENH: Convert loop fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title ENH: Convert loop fp rint into highway ENH: Convert loop unary fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title ENH: Convert loop unary fp rint into highway WIP: ENH: Convert loop unary fp rint into highway Apr 25, 2024
@luyahan luyahan changed the title WIP: ENH: Convert loop unary fp rint into highway [WIP]ENH: Convert loop unary fp rint into highway Apr 25, 2024
@Mousius
Copy link
Member

Mousius commented Apr 30, 2024

Hi @luyahan,

Have you measured if this changes/increases performance? Would be good to see some benchmarks 😸

Just a process point, I assume google/highway#2116 needs to be released before this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luyahan @Mousius