TYP: fix missing sys import in numeric.pyi

[Andrej730]

Fixed missing sys import that's needed after 8de2ed5 for these lines to work:

numpy/numpy/_core/numeric.pyi

Lines 11 to 14 in 7687245

	if sys.version_info >= (3, 10):
	from typing import TypeGuard
	else:
	from typing_extensions import TypeGuard

Perhaps, ping @rgommers

[mattip]

It would be nice to have this tested somehow so there is a test that fails without the fix, and passes afterwards.

[Andrej730]

It would be nice to have this tested somehow so there is a test that fails without the fix, and passes afterwards.

Without this fix stub file had an error "sys" is not defined Pylance reportUndefinedVariable and now it's resolved, shouldn't this cover the need for the test?

Regarding TypeGuard imports - TypeGuard is imported and is working either way even if if sys.version_info >= (3, 10): is broken, so it's just about missing sys error.

[rgommers]

Thanks @Andrej730.

Re testing: I don't think we can do anything about that. We test with Mypy (3 platforms, 3 different Python versions) , so this code is exercised. If different type checkers disagree, there's not much we can do. In this case, PyLance's complaint clearly seems correct; not sure why Mypy is happy with the missing import.

In this case, the problematic if-else can be removed completely though, because 3.10 is the lowest Python version we support now. @Andrej730 could you please do that instead?

[rgommers]

Or one better, revert all of commit 8de2ed5.

[Andrej730]

Or one better, revert all of commit 8de2ed5.

Removed the sys.version_info >= (3, 10) checks and kept typing_extensions as it still used for from typing_extensions import assert_type in tests and could be useful to resolve #26783.

Re testing: I don't think we can do anything about that. We test with Mypy (3 platforms, 3 different Python versions) , so this code is exercised. If different type checkers disagree, there's not much we can do. In this case, PyLance's complaint clearly seems correct; not sure why Mypy is happy with the missing import.

It seems something is missing - maybe this file is skipped somehow during tests or mypy configured to skip missing symbols?
Just noticed that the other line is also failing (after c8e2343) - "ComplexWarning" is unknown import symbol Pylance reportAttributeAccessIssue. Though this line is just safe to remove as ComplexWarning is not used but maybe there is also some other issue ongoing.

numpy/numpy/_core/numeric.pyi

Line 18 in 7687245

ComplexWarning as ComplexWarning,

[rgommers]

I have no time to dig into the mystery of why CI doesn't complain right now unfortunately, but I'd be happy to merge this.

Though this line is just safe to remove as ComplexWarning is not used but maybe there is also some other issue ongoing.

Good catch. Would you mind fixing that up as well?

[Andrej730]

Good catch. Would you mind fixing that up as well?

Sure, done.

[rgommers]

LGTM, in it goes. Thanks @Andrej730!