Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis ci separate compilation #317

Merged
merged 6 commits into from Jun 25, 2012

Conversation

cournape
Copy link
Member

Fix for separate compilation (distutils only).

This should fix #315. It includes an update to the travis file so that we test the separate build option on 2.7 and 3.2

@cournape
Copy link
Member Author

The travis output can be found there: http://travis-ci.org/#!/cournape/numpy

@travisbot
Copy link

This pull request passes (merged 465c2f4 into 699c2f3).

@teoliphant
Copy link
Member

Is there anyway you could rebase this into 1 commit? using git rebase -i

njsmith added a commit that referenced this pull request Jun 25, 2012
@njsmith njsmith merged commit 6a06466 into numpy:master Jun 25, 2012
@njsmith
Copy link
Member

njsmith commented Jun 25, 2012

The merge basically does that :-) See the merge diff:
6a06466

@teoliphant
Copy link
Member

Did you just click on the green button or did you type some git commands at the prompt?

@njsmith
Copy link
Member

njsmith commented Jun 25, 2012

I clicked the green button, which is equivalent to running the commands 'git checkout master && git merge --no-ff courenape/travis_ci_separate_compilation'. The --no-ff is the trick here, since it forces git to create a merge node, and the first parent of this merge node is always the previous state of the branch being merged into. So the diff between the merged tree and the first parent tree is the collapsed patch, and what github shows in its commit view.

If the point of your request was to ease cherry-picking, then try 'git cherry-pick -x -m1 6a06466'? The '-m1' means 'I want the change between this merge node and its first parent'.

@njsmith
Copy link
Member

njsmith commented Jun 25, 2012

Err, 'cournape', not 'courenape', of course -- sorry David!

@teoliphant
Copy link
Member

Very good. Thanks for the education. I like the pattern of just pressing the merge button where possible which Fernado Perez promotes. Your explanation gives me even more confidence.

Travis Oliphant
(on a mobile)
512-826-7480

On Jun 25, 2012, at 7:14 AM, njsmithreply@reply.github.com wrote:

Err, 'cournape', not 'courenape', of course -- sorry David!


Reply to this email directly or view it on GitHub:
#317 (comment)

luyahan pushed a commit to plctlab/numpy that referenced this pull request Apr 25, 2024
feat: Add vaddl_high_[s8|s16|s32|u8|u16|u32]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with NPY_SEPARATE_COMPILATION=1 fails
4 participants