New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis ci separate compilation #317
Travis ci separate compilation #317
Conversation
We only test 2.7 and 3.2 for now. If NumFocus does a donation, maybe we can reasonably expand to all the versions we care about.
The travis output can be found there: http://travis-ci.org/#!/cournape/numpy |
Is there anyway you could rebase this into 1 commit? using git rebase -i |
Travis ci separate compilation
The merge basically does that :-) See the merge diff: |
Did you just click on the green button or did you type some git commands at the prompt? |
I clicked the green button, which is equivalent to running the commands 'git checkout master && git merge --no-ff courenape/travis_ci_separate_compilation'. The --no-ff is the trick here, since it forces git to create a merge node, and the first parent of this merge node is always the previous state of the branch being merged into. So the diff between the merged tree and the first parent tree is the collapsed patch, and what github shows in its commit view. If the point of your request was to ease cherry-picking, then try 'git cherry-pick -x -m1 6a06466'? The '-m1' means 'I want the change between this merge node and its first parent'. |
Err, 'cournape', not 'courenape', of course -- sorry David! |
Very good. Thanks for the education. I like the pattern of just pressing the merge button where possible which Fernado Perez promotes. Your explanation gives me even more confidence. Travis Oliphant On Jun 25, 2012, at 7:14 AM, njsmithreply@reply.github.com wrote:
|
feat: Add vaddl_high_[s8|s16|s32|u8|u16|u32]
Fix for separate compilation (distutils only).
This should fix #315. It includes an update to the travis file so that we test the separate build option on 2.7 and 3.2