Backport 1.8 doc fixes #4406
Merged
Backport 1.8 doc fixes #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bits are also rephrased and nan is replaced by NaN where appropriate.
The documentation needs to be in umathmodule.c as that is where ldexp and frexp and defined. I moved the current documention from add_newdocs.py to ufunc_docstrings.py, manually translated them into C strings, and inserted them into umathmodule.c. Closes numpy#2354.
Add the fact that for pickled files, a file-like object must also support the readline() method. Closes numpy#2807.
The documentation misrepresented what happened, leaving out division by the total number of sample points. Also run spellcheck over function_base.py and twodim_base.py and break some long lines. Closes numpy#2423.
|
please see the questions in the master pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1.8 document fixes for
gh-3563
gh-2354
gh-2807
gh-2423