BUG: fix uninitialized use of size 1 reductions #4535
Conversation
Size 1 reductions do not intiialize the iterator fully as normal reductions which triggers uninitialized use in NpyIter_IsFirstVisit. To fix this check the size of the iterator and return true if it only has size 1.
|
LGTM, thanks Julian. |
BUG: fix uninitialized use of size 1 reductions
|
I wonder if we should backport it, due to the iterator changes the valgrind warnings have disappeared so maybe its not even required anymore |
The FirstVisit function uses this, but when the reduction is over a single element it isn't considered a reduction. This is fine, however the reduce pos must still be initialized to 0 in that case. Also changes the check order so that it is not necessary to initialize the outerstrides as well. See also numpygh-4134, and numpygh-4535.
|
I'm getting a bit lost on this subject. AFAIK, there have been two changes not backported, this and Sebastian's PR which reverts part of this. Both are pretty small, so I'd be inclined to backport both and maybe squash the two commits. And when that's done, I may have got vagrant figured out and running ;) @certik BTW, I'm thinking it might be worth making numpy-vendor a numpy repository so we can keep it updated. |
The FirstVisit function uses this, but when the reduction is over a single element it isn't considered a reduction. This is fine, however the reduce pos must still be initialized to 0 in that case. Also changes the check order so that it is not necessary to initialize the outerstrides as well. See also numpygh-4134, and numpygh-4535.
|
mine "fix" was obsoleted by sebers, I'll backport it |
|
@charris https://github.com/certik/numpy-vendor contains binaries originally taken from https://github.com/numpy/vendor, so merging those two repos is the way to go. |
|
@juliantaylor Tomorrow would be fine. I'm just starting to get vagrant figured out, so if you would make the binaries that would help. @rgommers I looks like numpy-vendor wasn't a fork of vendor, so merging will require a bit of work. There are instructions at http://blog.caplin.com/2013/09/18/merging-two-git-repositories/comment-page-1/ . |
Size 1 reductions do not intiialize the iterator fully as normal
reductions which triggers uninitialized use in NpyIter_IsFirstVisit.
To fix this check the size of the iterator and return true if it only
has size 1.