FIX isfileobj accepts write-mode files under PY3 #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def tempdir(): | ||
| tmpdir = mkdtemp(prefix="numpy_test_compat") | ||
| yield tmpdir | ||
| shutil.rmtree(tmpdir) |
There was a problem hiding this comment.
we have another of these in test_io.py, it should probably be moved to testing.utils
|
@juliantaylor I think I addressed your comments. I rebased as 2 separate commits. |
|
Note: we could have used |
|
unfortunately its also not available in 2.7, so like all python3 stuff maybe we can use it in 2020 (copying it into numpy is also no good idea, ipython did that and it broke when with py3.4) thanks for the fix, note the commit prefix for bugfixes should be |
juliantaylor
added a commit
that referenced
this pull request
Jun 30, 2014
FIX isfileobj accepts write-mode files under PY3
|
Thanks, I'll try to follow the commit conventions next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Python 3, files open in write mode were not recognized as file objects, triggering large memory copies with
np.save.