Fixup of PR #4921 #4982
Merged
Fixup of PR #4921 #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions currently fail randomly for Python < 3.x because they use PyObject_Cmp, which looks at addresses for NaN objects. The fix is to use PyObject_RichCompareBool, which is available in Python >= 2.6. Note that for Python 2.6 and 2.7, PyObject_RichCompareBool falls back on PyObject_Cmp when an object doesn't provide rich compare. Closes numpy#4903.
Closed
|
can you add a testcase? |
There is a random element to these tests, so that they may fail to fail when python compare is being used instead of richcompare.
|
Added. I note the numpy maximum/minimum for objects behaves differently than Python3 max/min. |
|
OK, putting this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Fix NaN handling in npy_ObjectMax and npy_ObjectMin.
These functions currently fail randomly for Python < 3.x because they
use PyObject_Cmp, which looks at addresses for NaN objects. The fix is
to use PyObject_RichCompareBool, which is available in Python >= 2.6.
Note that for Python 2.6 and 2.7, PyObject_RichCompareBool falls back on
PyObject_Cmp when an object doesn't provide rich compare.
Closes #4903.