BUG TST: Closes #5313 PyArray_AsCArray caused segfault and adds testcase #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensing
force-pushed
the
testcase_AsCArray
branch
from
4762bde
to
2e199f7
Compare
hensing
force-pushed
the
testcase_AsCArray
branch
from
2e199f7
to
b32b097
Compare
|
So this is a backport to 1.9.x of things already in master? |
|
@hensing I've split the PR into two parts. The test is now a PR against master, rebased for backport, and the fix is the same cherrypick. You are still the author for both. |
|
Closing, tests applied in both master and 1.9.x and fix backported. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request combines a cherry pick of a4163c4 (BUG: Closes #5313 PyArray_AsCArray caused segfault) and adds new test cases for PyArray_AsCArray.
Thus pull-request #5330 is now superfluous.