Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make f2py an executable module #5565

Merged
merged 1 commit into from Mar 9, 2015

Conversation

juliantaylor
Copy link
Contributor

allows pep 338 execution via python -mnumpy.f2py

@juliantaylor
Copy link
Contributor Author

one could remove some duplication by using that file in f2py/setup.py where the shebang is added, thoguh I don't know whats the best way to get the f2py module path. is setup.py ever executed out of source?

@juliantaylor
Copy link
Contributor Author

updated with less duplication after based on suggestion of @mgaitan, but I don't know if that works on windows
@jaimefrio can you test if the f2py binary still works?

@jaimefrio
Copy link
Member

It will have to wait until Tuesday: I have retired my old Windows laptop, and now have a shiny Mac, but still have access to plenty of Windows boxes at work. What exactly do you want me to test?

@rgommers
Copy link
Member

rgommers commented Mar 8, 2015

The main numpy setup.py is exec'd by setupegg.py, but I don't think you have to worry about f2py/setup.py usage other than via distutils/setuptools.

@rgommers
Copy link
Member

rgommers commented Mar 8, 2015

I guess test that python -mnumpy.f2py <any_fortran_file> works + that scipy builds?

@juliantaylor
Copy link
Contributor Author

no, I need tested that the f2py "binaries" still execute, they changed from text files with #!/usr/bin/python to #!/bin/sh

@juliantaylor
Copy link
Contributor Author

mh just booted my windows vm, does not work :(

allows pep 338 execution via python -mnumpy.f2py
@juliantaylor
Copy link
Contributor Author

updated to a different method

@rgommers
Copy link
Member

rgommers commented Mar 8, 2015

If you tested this and it does work on Windows (+ TravisCI is happy), then I'd say go ahead and merge it.

juliantaylor added a commit that referenced this pull request Mar 9, 2015
ENH: make f2py an executable module
@juliantaylor juliantaylor merged commit 29c019a into numpy:master Mar 9, 2015
@juliantaylor juliantaylor deleted the pep338-f2py branch March 9, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants