Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MANT: searchsorted should return base ndarrays always #6206

Merged
merged 1 commit into from Aug 17, 2015
Merged

MANT: searchsorted should return base ndarrays always #6206

merged 1 commit into from Aug 17, 2015

Conversation

jaimefrio
Copy link
Member

No description provided.

@njsmith
Copy link
Member

njsmith commented Aug 14, 2015

Could you add a test for digitize too, since that was the change that we know actually broke code?

@jaimefrio
Copy link
Member Author

Added the digitize tests.

@njsmith
Copy link
Member

njsmith commented Aug 17, 2015

Thanks Jaime!

@homu r+

@charris: This needs a 1.10 backport -- is there some tag that should be added or issue opened or something?

@homu
Copy link
Contributor

homu commented Aug 17, 2015

📌 Commit 649ede4 has been approved by njsmith

@homu
Copy link
Contributor

homu commented Aug 17, 2015

⌛ Testing commit 649ede4 with merge 4186b6d...

homu added a commit that referenced this pull request Aug 17, 2015
@homu
Auto merge of #6206 - jaimefrio:searchsorted_ndarray, r=njsmith
4186b6d 
MANT: searchsorted should return base ndarrays always
@homu
Copy link
Contributor

homu commented Aug 17, 2015

☀️ Test successful - status

@homu homu merged commit 649ede4 into numpy:master Aug 17, 2015
@jaimefrio jaimefrio deleted the searchsorted_ndarray branch August 17, 2015 06:54
@charris
Copy link
Member

charris commented Aug 17, 2015

@njsmith I've been using the 1.10.0 release milestone as a tag.

@charris charris mentioned this pull request Aug 17, 2015
Merged
charris referenced this pull request Aug 17, 2015
@charris
Merge pull request #6212 from charris/backport-gh-6206
ddf4430 
MANT: searchsorted should return base ndarrays always
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaimefrio @njsmith @homu @charris