Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix refcounting for string comparison in array_richcompare #6254

Merged
merged 1 commit into from Aug 27, 2015

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Aug 27, 2015

Regression introduced in 4b1f508

Closes gh-6250.

@njsmith njsmith added this to the 1.10 blockers milestone Aug 27, 2015
@njsmith
Copy link
Member Author

njsmith commented Aug 27, 2015

This will need a backport to the 1.10 branch too.

@pitrou
Copy link
Member

pitrou commented Aug 27, 2015

Has Numpy ever thought of running the test suite in a "reference leak hunting" mode like CPython does? That would help catch those regressions more easily.

@njsmith
Copy link
Member Author

njsmith commented Aug 27, 2015

Not to my knowledge. Is there a reference for how this is done?
On Aug 27, 2015 1:40 AM, "Antoine Pitrou" notifications@github.com wrote:

Has Numpy ever thought of running the test suite in a "reference leak
hunting" mode like CPython does? That would help catch those regressions
more easily.


Reply to this email directly or view it on GitHub
#6254 (comment).

@pitrou
Copy link
Member

pitrou commented Aug 27, 2015

It's quite a messy thing in CPython's own regression test script, but I managed to rewrite it more cleanly for the llvmlite test suite, for use with plain unittest. I don't know whether it's compatible with nose:
https://github.com/numba/llvmlite/blob/master/llvmlite/tests/customize.py

The main requirement is the need for a debug Python interpreter.

charris added a commit that referenced this pull request Aug 27, 2015
BUG: Fix refcounting for string comparison in array_richcompare
@charris charris merged commit f907d7b into numpy:master Aug 27, 2015
@charris
Copy link
Member

charris commented Aug 27, 2015

Thanks Nathaniel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants