-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check lower base limit in base_repr. #6298
Conversation
It would be nice to add a test that the error is properly raised somewhere here. Also, since you are working on this function, the docstring comment on it only handling positive |
Should squash the commits. Use `git rebase -i HEAD^^' in the branch and follow directions, then force push to origin. |
Also needs a test for raising the error. Should go in |
@nbeaver could you please address the comments? It would be good to get this PR merged. |
9e38ea4
to
cc63f77
Compare
@jaimefrio @charris I have squashed the commits, fixed the docstring, and added the test as requested. There was some kind of merge problem, but I rebased the recent master and was able to fix it. @rgommers Thanks for the reminder. |
2b8077d
to
7fa6aea
Compare
Check lower base limit in base_repr.
Thanks @nbeaver . |
A minor fix to ensure the range is as expected. (This is my first pull request, so let me know if I missed something in the protocol.)