ENH: enabled extra_link_args in OpenBLAS segment #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra_link_args is sadly not intrinsically used for many parts of the system_info code. This commit adds the linking properties stored when using extra_link_args in the openblas section to bypass any difficulties in the usage of OpenBLAS. This is especially helpful when linking against external LAPACK libraries which requires -lgfortran and possibly -lm for correct linking.
|
LGTM. @rgommers, @juliantaylor Comment? |
charris
added a commit
that referenced
this pull request
Sep 22, 2015
ENH: enabled extra_link_args in OpenBLAS segment
|
Thanks @zerothi . |
charris
added a commit
that referenced
this pull request
Sep 22, 2015
|
thanks for persisting and getting the solution over the finish line @zerothi! |
|
Thanks for the great package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extra_link_argsis sadly not intrinsically usedfor many parts of the system_info code.
This commit adds the linking properties stored
when using
extra_link_argsin the openblas sectionto bypass any difficulties in the usage of OpenBLAS.
This is especially helpful when linking against external
LAPACK libraries which requires
-lgfortranand possibly-lmfor correct linking.This PR is more general than #5855 without making
site.cfgmore complex, which I think is good.This PR supersedes #5855 and is a complement to the already merged PR #5597
#5855 will be closed to prefer this PR.