TST: test itemsize changes in views of 1d fortran arrays #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, introduce a boolean `np.is_relaxed_strides` describing whether relaxed strides is enabled.
| @@ -5457,6 +5457,47 @@ def test_relaxed_strides(self): | |||
| shape, strides = get_buffer_info(arr, ['C_CONTIGUOUS']) | |||
| assert_(strides[-1] == 8) | |||
|
|
|||
| # test views of different dtype sizes. These tests will break when | |||
| # relaxed strides are enabled | |||
| @dec.skipif(np.ones(1).strides[0] == np.iinfo(np.intp).max) | |||
There was a problem hiding this comment.
This is probably unsafe as the strides are reset to the usual for release. Safer would be to check if ones((2,1), order='F') is c_contiguous (as well as f_contiguous).
|
Thanks for doing this. |
|
-1 to adding a public top-level attribute np.is_relaxed_strides. Underscored or hidden in some internal module is fine, but the top level namespaxe is crowded enough already and we don't want to get stuck supporting and documenting this thing for years to come. |
|
☔ The latest upstream changes (presumably #7941) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Oops, deleted a branch that was still open. I'll leave it like this though, this is mostly historical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @charris suggested in #6684, here are some tests of views of 1d arrays using different dtype sizes, checking for the 1.9.3 behavior.
Also, this adds a boolean
np.is_relaxed_stridesdescribing whether relaxed strides is enabled.I'm not sure if you want to merge, but here it is just in case.